Support user regex filter for note trigger #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why hasn't this been reviewed and checked in? @omehegan can you please take a look. |
atrifex
reviewed
Aug 1, 2019
| @@ -67,8 +73,8 @@ protected CauseData retrieveCauseData(NoteHook hook) { | |||
| .withTargetProjectId(hook.getMergeRequest().getTargetProjectId()) | |||
| .withBranch(hook.getMergeRequest().getSourceBranch()) | |||
| .withSourceBranch(hook.getMergeRequest().getSourceBranch()) | |||
| .withUserName(hook.getMergeRequest().getLastCommit().getAuthor().getName()) | |||
| .withUserEmail(hook.getMergeRequest().getLastCommit().getAuthor().getEmail()) | |||
| .withUserName(hook.getUser().getUsername()) | |||
There was a problem hiding this comment.
This is not backward compatible. People that are relying on this being the user name and email of committer will see bugs.
Might be useful to create new field that deals with the hook user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support user regex filter when trigger type is note.If the username who wrote comment like "merge please" not match the user regex configured in job configuration, the note will not trigger build.