Update windows 'notifu' and 'SnoreToast' to be non-blocking

jolicode · Sep 28, 2024 · a4ed372 · a4ed372
1 parent 9c23907
commit a4ed372
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Driver/NotifuDriver.php b/src/Driver/NotifuDriver.php
@@ -13,6 +13,7 @@
 
 use Joli\JoliNotif\Notification;
 use JoliCode\PhpOsHelper\OsHelper;
+use Symfony\Component\Process\Process;
 
 /**
  * This driver can be used on Windows Seven and provides its own binaries if
@@ -71,4 +72,14 @@ protected function getCommandLineArguments(Notification $notification): array
 
         return $arguments;
     }
+
+    protected function launchProcess(Process $process): void
+    {
+        $process->start();
+    }
+
+    protected function handleExitCode(Process $process): bool
+    {
+        return true;
+    }
 }
diff --git a/src/Driver/SnoreToastDriver.php b/src/Driver/SnoreToastDriver.php
@@ -75,8 +75,13 @@ protected function getCommandLineArguments(Notification $notification): array
         return $arguments;
     }
 
+    protected function launchProcess(Process $process): void
+    {
+        $process->start();
+    }
+
     protected function handleExitCode(Process $process): bool
     {
-        return 0 < $process->getExitCode();
+        return true;
     }
 }