Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch (-w) #196

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix watch (-w) #196

wants to merge 4 commits into from

Commits on Mar 12, 2019

  1. Fix watch (-w) 

    Delete `nextToken` from kwargs, otherwise this will cause the response
to be stale / the same always.

This should get improved probably to update `kwargs['startTime']`
probably, but it is not clear to me if we could use the `max` or `min`
from the received events here.  Maybe with some offset being applied for
safety (`self.parse_datetime("5m ago")`)?
    @blueyed
    blueyed committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    49a9a37 View commit details
    Browse the repository at this point in the history

  2. qa: add "noqa: C901" for list_logs 

    Eventually this should get refactored, but it seems better to just
silence mccabe for now.

It also uses the default max-complexity for the rest now.
    @blueyed
    blueyed committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    7ec9230 View commit details
    Browse the repository at this point in the history

  3. generator: use StopIteration

    @blueyed
    blueyed committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    d38c378 View commit details
    Browse the repository at this point in the history

  4. generator: watch: use max startTime from events

    @blueyed
    blueyed committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    883a473 View commit details
    Browse the repository at this point in the history