Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multiple generator threads when filtering to more than 100 log streams; fixes #82 #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use multiple generator threads when filtering to more than 100 log streams; fixes #82 #84

wants to merge 1 commit into from

Conversation

mmaslowskicc
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 92.647% when pulling 581ef5c on mmaslowskicc:log-streams-limit into 021691b on jorgebastida:master.

@jorgebastida
Copy link
Owner

I do like this idea, but I think the code would benefit from a few changes:

  • Handle thread termination when the program has to exit.
  • Share a deque to avoid duplicated log lines between generators?

If anybody is happy to jump into updating this PR, I'll happily merge it.

@jorgebastida jorgebastida added this to the 0.12 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
update required
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@mmaslowskicc @coveralls @jorgebastida