Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wait for upstream] Add nodes to adjust the volume of the auto speaking #1715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kanazawanaoaki
Copy link
Contributor

@Kanazawanaoaki Kanazawanaoaki commented Nov 3, 2022

I wrote a node to change the volume of audible_warning and tweet in order to adjust the volume of warnings etc. that pr2 automatically speaks during lab meeting.

this PR needs jsk-ros-pkg/jsk_roseus#729 and #1725 .

related to #1724

cc. @knorth55 @iory

@Kanazawanaoaki Kanazawanaoaki changed the title [WIP] Add nodes to adjust the volume of the auto speaking [wait for upstream] Add nodes to adjust the volume of the auto speaking Nov 13, 2022
@Kanazawanaoaki
Copy link
Contributor Author

Added volume controls for /tweet_client_tablet, /tweet_client_uptime, /tweet_client_warning and /tweet_client_worktime.

@Kanazawanaoaki
Copy link
Contributor Author

I added apps with temporary image.

@knorth55
Copy link
Member

can you move these apps in jsk_robot_startup and use the same apps for fetch?

@knorth55
Copy link
Member

@Kanazawanaoaki can you open the similar PR whose target branch is develop/pr2?

@Kanazawanaoaki
Copy link
Contributor Author

Sorry for the delay. I open #1744.

@Kanazawanaoaki
Copy link
Contributor Author

Currently, develop/pr2 and develop/fetch only include changes related to the each robot, but I think the following changes and discussions are ideally needed for this functionality.

  • Create and change icons.
  • Determine the location of the App. I have now added Apps to jsk_pr2_startup and jsk_fetch_startup, but since fetch and pr2 are common as programs to be executed, I thought it would be OK to add them to jsk_robot_startup's App if there are no problems.
  • Come up with a name for your App or program

@Kanazawanaoaki Kanazawanaoaki force-pushed the add-speck-volume-lower branch 2 times, most recently from 46eb4ac to 7f22892 Compare December 2, 2022 18:04
@Kanazawanaoaki
Copy link
Contributor Author

I changed the location of the apps and the icon images, and tested the contents of this PR in robot body with #1746 and #1745.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants