Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix summary being treated as non-interactive #985

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 6, 2024

Fixes: #656

This ensures that summary is treated as an interactive element so it doesn't raise a false positive with the no-static-element-interactions lint rule.

@khiga8
Copy link
Contributor Author

khiga8 commented May 6, 2024

I am going to test bumping axobject-query to the latest 4.0.0 since that might resolve this bug.

If bumping this package should be done with more care/breaks things, then I may instead suggest a hard-coded update to src/util/isInteractiveElement.js to immediately resolve this bug.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (882bd4d) to head (07d3353).

Current head 07d3353 differs from pull request most recent head 89301a8

Please upload reports for the commit 89301a8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   99.03%   99.02%   -0.01%     
==========================================
  Files         107      105       -2     
  Lines        1651     1638      -13     
  Branches      581      581              
==========================================
- Hits         1635     1622      -13     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khiga8 khiga8 marked this pull request as ready for review May 6, 2024 18:22
@khiga8 khiga8 requested a review from ljharb May 7, 2024 11:41
@ljharb ljharb requested a review from jessebeach May 8, 2024 14:35
@aarfing
Copy link

aarfing commented May 22, 2024

Good job. Was hoping a fix was one the way for this issue :)

@ljharb
Copy link
Member

ljharb commented Jun 20, 2024

rebased, but it's failing.

@khiga8
Copy link
Contributor Author

khiga8 commented Jun 20, 2024

@ljharb I see the new failures are related to commit 6a048da.

Is this needed?

@ljharb
Copy link
Member

ljharb commented Jun 20, 2024

@khiga8 we're stuck on an older version of aria-query and axobject-query, which don't have "summary" in the right place, so i think it is still needed.

@jessebeach
Copy link
Collaborator

jessebeach commented Jun 20, 2024

@ljharb I'm the blocker here. Would you like permission to publish updates for aria-query and axobject-query? I'd like to remove myself from the dependency chain here so folks are unblocked. I'm flat out with work-work and family lately and I don't have the bandwidth to jump in here.

@ljharb
Copy link
Member

ljharb commented Jun 20, 2024

@jessebeach i'd be more than happy to help maintain those projects! I'd still want you to weigh in on the dequal breaking change stuff tho, which is the blocker for us upgrading.

@jessebeach
Copy link
Collaborator

i'd be more than happy to help maintain those projects

You're a maintainer now. That's one hurdle =D

@ljharb
Copy link
Member

ljharb commented Jun 20, 2024

@jessebeach thanks! do i need npm ownership as well?

@jessebeach
Copy link
Collaborator

@jessebeach thanks! do i need npm ownership as well?

I invited you to both NPM projects. That's 2 hurdles =D

@ljharb
Copy link
Member

ljharb commented Sep 4, 2024

I've rebased this onto main, which has unpinned axobject-query, but aria-query still needs a release for us to be able to unpin it, and presumably at that point this PR will pass tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

summary should be interactive
4 participants