Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: add subprotocol for token-authenticated websockets #1407

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

proposal: add subprotocol for token-authenticated websockets #1407

wants to merge 3 commits into from

Commits on Mar 14, 2024

  1. add subprotocol for token-authenticated websockets 

    follows kubernetes' example of smuggling the token in the subprotocol itself
    @minrk
    minrk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9627c7c View commit details
    Browse the repository at this point in the history

  2. include websocket protocol in response 

    Chrome doesn't accept websocket connections if protocol is requested but not provided
    @minrk
    minrk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    aef6348 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. subprotocol token may be url-encoded

    @minrk
    minrk committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b39f15e View commit details
    Browse the repository at this point in the history