Fix apparent logic error in _log

Make noise when JUPYTER_DOCKER_STACKS_QUIET is empty
jupyter · Nov 12, 2021 · f974efe · f974efe
1 parent c00d35a
commit f974efe
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/base-notebook/start.sh b/base-notebook/start.sh
@@ -8,7 +8,7 @@ set -e
 # always log errors and warnings, but can be silenced by setting
 # JUPYTER_DOCKER_STACKS_QUIET.
 _log () {
-    if [[ "$*" == "ERROR:"* ]] || [[ "$*" == "WARNING:"* ]] || [[ "$JUPYTER_DOCKER_STACKS_QUIET" != "" ]]; then
+    if [[ "$*" == "ERROR:"* ]] || [[ "$*" == "WARNING:"* ]] || [[ "$JUPYTER_DOCKER_STACKS_QUIET" == "" ]]; then
         echo "$@"
     fi
 }
@@ -207,7 +207,6 @@ else
     # NOTE: This hook is run as the user we started the container as!
     run-hooks /usr/local/bin/before-notebook.d
 
-    unset_explicit_env_vars
     _log "Executing the command:" "${cmd[@]}"
     exec "${cmd[@]}"
 fi