Enable color terminal in common cases #826
Conversation
There was a problem hiding this comment.
I suppose my main concern is that as commented in #815, this doesn't do anything for the Terminal plugin, and for an ad-hoc shell, the same should be able to be achieved by setting e.g. -e TERM=xterm-256color.
I guess it does no harm, unless we know of a situation where a terminal client doesn't support color.
base-notebook/Dockerfile
Outdated
| # and in the default bash.bashrc for the case where the user home directory gets | ||
| # overridden. | ||
| RUN sed -i 's/^#force_color_prompt=yes/force_color_prompt=yes/' /etc/skel/.bashrc && \ | ||
| sed -i 's/^#force_color_prompt=yes/force_color_prompt=yes/' /etc/bash.bashrc |
There was a problem hiding this comment.
Does this second sed have any effect?
docker run -it --rm ubuntu:bionic-20180526@sha256:c8c275751219dadad8fa56b3ac41ca6cb22219ff117ca98fe82b42f24e1ba64e grep -r force_color_prompt /etc
/etc/skel/.bashrc:#force_color_prompt=yes
/etc/skel/.bashrc:if [ -n "$force_color_prompt" ]; then
/etc/skel/.bashrc:unset color_prompt force_color_prompt
There was a problem hiding this comment.
You are correct. I mistakenly thought the bash.bashrc also respected this flag. I've removed the second line and will update the PR description so that it correctly reflects what the PR enables.
|
@javabrett I found the terminal prompt in classic notebook and lab had color with these changes when running |
|
|
Sets
force_color_prompt=yesin/etc/skel/.bashrcto configure color prompts when adding a newNB_USERat image build time.Sets the same key/value in/etc/bash.bashrcto configure color prompts when host mounting a.bashrcfile that respects the setting at runtime.For #815