Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats Effect 3.x initial implementation #1128

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cmcmteixeira
Copy link

Details can be found here

@ivantopo
Copy link
Contributor

ivantopo commented Mar 1, 2022

@cmcmteixeira please take a look at this issue when trying to compile for Scala 2.11

@dpsoft
Copy link
Contributor

dpsoft commented Mar 1, 2022

There is not support for scala 2.11. All current Cats Effect releases are published for Scala 2.12, 2.13, 3.0

@@ -242,9 +242,9 @@ lazy val `kamon-cats-io` = (project in file("instrumentation/kamon-cats-io"))
kanelaAgent % "provided",
{
if(scalaBinaryVersion.value == "2.11")
"org.typelevel" %% "cats-effect" % "2.0.0" % "provided"
"org.typelevel" %% "cats-effect" % "3.3.5" % "provided"
Copy link
Contributor

@hughsimpson hughsimpson Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be saner to split this into kamon-cats-effect2/kamon-cats-effect-3 ? I'm picturing people on cats effect 2 bumping kamon and suddenly their instrumentation breaks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the best way to go indeed.. Just gotta make it work first 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants