Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamon-redis supports redisson client #1190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Whitilied
Copy link

No description provided.

@Whitilied
Copy link
Author

Whitilied commented Jul 19, 2022

linked to
#1177

@Whitilied
Copy link
Author

@ivantopo


Kamon.clientSpanBuilder(commandName, "redisson")
.tag("db.operation", commandName)
.tagMetrics("db.system", "redis")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Whitilied, do you think it would be possible to ass the db.statement tag here with the contents of that local statements variable? I'm just looking at the OpenTelemetry semantic conventions (screenshot below) and thinking it would be nice to set that field as well, if we have it!

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gree with u

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivantopo change to the OpenTelemetry's Semantic Conventions

@anujprashar
Copy link

Hi @Whitilied @ivantopo When can we expect this feature to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants