Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kamon-pekko tolerant of null dispatcherPrerequisites #1361

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

pjfanning
Copy link
Contributor

relates to #1352

unit tests pass and tested with https://github.com/pjfanning/kamon-pekko-http-test

The NPE may pop up in other use cases but this sorts the one seen in #1352

I know a fuller fix is needed - one that ensures the dispatcherPrerequisites are found but that can be done independently.

@hughsimpson
Copy link
Contributor

I've been spending some time today trying to figure out what's causing this (cf #1362) and honestly I'm not sure, but it seems like various pieces of instrumentation aren't working... Especially in scala 2.13. Scala 3 doesn't seem to have any issues.. so that's odd. Would rather the instrumentation tests passed for pekko 1.1, because otherwise we're probably hiding errors...

@pjfanning
Copy link
Contributor Author

@hughsimpson feel free to do a new PR that sorts out the instrumentation issue. This PR is useful as far as I am concerned because it stops Kamon from crashing the JVM.

To repeat what I said in the PR description:
I know a fuller fix is needed - one that ensures the dispatcherPrerequisites are found but that can be done independently.

@hughsimpson hughsimpson merged commit a478d3b into kamon-io:master Sep 17, 2024
2 checks passed
@pjfanning pjfanning deleted the kamon-npe branch September 17, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants