Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add April 2024 vPTG Kata session recap #246

Merged
merged 3 commits into from
May 22, 2024
Merged

Add April 2024 vPTG Kata session recap #246

merged 3 commits into from
May 22, 2024

Conversation

ildikov
Copy link
Collaborator

@ildikov ildikov commented May 21, 2024

This patch adds a blog post that summarizes the discussions the community had at the last PTG. It also adds an author file to note the author's name and affiliation.

This patch adds a blog post that summarizes the discussions the community
had at the last PTG. It also adds an author file to note the author's name
and affiliation.

Signed-off-by: Ildiko Vancsa <[email protected]>
Copy link

netlify bot commented May 21, 2024

Deploy Preview for katacontainers ready!

Name Link
🔨 Latest commit 22e274f
🔍 Latest deploy log https://app.netlify.com/sites/katacontainers/deploys/664dfd020fefd300080e4ec9
😎 Deploy Preview https://deploy-preview-246--katacontainers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ildiko Vancsa <[email protected]>
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, with one minor formatting change suggested that might add clarity. If you are updating it then squashing the two commits together might be helpful for cleaner commit history as well?


Contributors also raised the question whether or not to switch over to runtime-rs as the default runtime, but no decision was made during the session.

## Hypervisor Updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I probably should have picked up on this in the etherpad review, but I'm not sure if the current formatting makes it clear that the hypervisor updates are specific to working on getting those hypervisors supported by runtime-rs? Maybe the overall section heading should be # Runtime and Hypervisor Updates -> # Runtime Updates and this heading should be ## Hypervisor Updates -> ### Runtime-rs Hypervisor Support Updates?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the headers in the next commit. Does that clarify the content a little better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - that looks good. Thanks!

Signed-off-by: Ildiko Vancsa <[email protected]>
@ildikov
Copy link
Collaborator Author

ildikov commented May 22, 2024

@stevenhorsman I hopefully fixed your comment. I can also squash the commits at merge, does that work for you?

@ildikov ildikov merged commit 7bbf902 into main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants