Reach PHPStan level 3

.phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 2
+    level: 3
 
     paths:
         - src/

src/Redmine/Api/Group.php

@@ -63,7 +63,7 @@ public function listing($forceUpdate = false)
      *
      * @throws MissingParameterException Missing mandatory parameters
      *
-     * @return \SimpleXMLElement
+     * @return string|false
      */
     public function create(array $params = [])
     {

src/Redmine/Api/Issue.php

@@ -76,7 +76,7 @@ public function show($id, array $params = [])
      *
      * @param array $params the new issue data
      *
-     * @return \SimpleXMLElement
+     * @return string|false
      */
     public function create(array $params = [])
     {
@@ -174,6 +174,7 @@ public function removeWatcher($id, $watcherUserId)
      */
     public function setIssueStatus($id, $status)
     {
+        /** @var IssueStatus */
         $api = $this->client->getApi('issue_status');
 
         return $this->update($id, [
@@ -204,31 +205,37 @@ public function addNoteToIssue($id, $note, $privateNote = false)
     private function cleanParams(array $params = [])
     {
         if (isset($params['project'])) {
+            /** @var Project */
             $apiProject = $this->client->getApi('project');
             $params['project_id'] = $apiProject->getIdByName($params['project']);
             unset($params['project']);
             if (isset($params['category'])) {
+                /** @var IssueCategory */
                 $apiIssueCategory = $this->client->getApi('issue_category');
                 $params['category_id'] = $apiIssueCategory->getIdByName($params['project_id'], $params['category']);
                 unset($params['category']);
             }
         }
         if (isset($params['status'])) {
+            /** @var IssueStatus */
             $apiIssueStatus = $this->client->getApi('issue_status');
             $params['status_id'] = $apiIssueStatus->getIdByName($params['status']);
             unset($params['status']);
         }
         if (isset($params['tracker'])) {
+            /** @var Tracker */
             $apiTracker = $this->client->getApi('tracker');
             $params['tracker_id'] = $apiTracker->getIdByName($params['tracker']);
             unset($params['tracker']);
         }
         if (isset($params['assigned_to'])) {
+            /** @var User */
             $apiUser = $this->client->getApi('user');
             $params['assigned_to_id'] = $apiUser->getIdByUsername($params['assigned_to']);
             unset($params['assigned_to']);
         }
         if (isset($params['author'])) {
+            /** @var User */
             $apiUser = $this->client->getApi('user');
             $params['author_id'] = $apiUser->getIdByUsername($params['author']);
             unset($params['author']);

src/Redmine/Api/Membership.php

@@ -121,7 +121,7 @@ public function removeMember($projectId, $userId, array $params = [])
     {
         $memberships = $this->all($projectId, $params);
         if (!isset($memberships['memberships']) || !is_array($memberships['memberships'])) {
-            return;
+            return false;
         }
         $removed = false;
         foreach ($memberships['memberships'] as $membership) {

src/Redmine/Api/Project.php

@@ -106,7 +106,7 @@ public function show($id, array $params = [])
      *
      * @throws MissingParameterException
      *
-     * @return \SimpleXMLElement
+     * @return string|false
      */
     public function create(array $params = [])
     {

src/Redmine/Client/NativeCurlClient.php

@@ -4,7 +4,6 @@
 
 namespace Redmine\Client;
 
-use Redmine\Api;
 use Redmine\Exception\ClientException;
 
 /**
@@ -246,7 +245,7 @@ private function request(string $method, string $path, string $body = ''): bool
     /**
      * Prepare the request by setting the cURL options.
      *
-     * @return resource a cURL handle on success, <b>FALSE</b> on errors
+     * @return resource|\CurlHandle a cURL handle on success, <b>FALSE</b> on errors
      */
     private function createCurl(string $method, string $path, string $body = '')
     {

tests/Integration/GroupXmlTest.php

@@ -23,6 +23,7 @@ public function setup(): void
 
     public function testCreateBlank()
     {
+        /** @var \Redmine\Api\Group */
         $api = $this->client->getApi('group');
         $this->assertInstanceOf('Redmine\Api\Group', $api);
 
@@ -34,7 +35,9 @@ public function testCreateBlank()
 
     public function testCreateComplex()
     {
-        $res = $this->client->getApi('group')->create([
+        /** @var \Redmine\Api\Group */
+        $api = $this->client->getApi('group');
+        $res = $api->create([
             'name' => 'Developers',
             'user_ids' => [3, 5],
         ]);
@@ -54,6 +57,7 @@ public function testCreateComplex()
 
     public function testUpdateNotImplemented()
     {
+        /** @var \Redmine\Api\Group */
         $api = $this->client->getApi('group');
         $this->assertInstanceOf('Redmine\Api\Group', $api);
 

tests/Integration/IssueCategoryXmlTest.php

@@ -22,6 +22,7 @@ public function setup(): void
 
     public function testCreateBlank()
     {
+        /** @var \Redmine\Api\IssueCategory */
         $api = $this->client->getApi('issue_category');
         $this->assertInstanceOf('Redmine\Api\IssueCategory', $api);
 
@@ -33,6 +34,7 @@ public function testCreateBlank()
 
     public function testCreateComplex()
     {
+        /** @var \Redmine\Api\IssueCategory */
         $api = $this->client->getApi('issue_category');
         $res = $api->create('otherProject', [
             'name' => 'test category',
@@ -48,6 +50,7 @@ public function testCreateComplex()
 
     public function testUpdate()
     {
+        /** @var \Redmine\Api\IssueCategory */
         $api = $this->client->getApi('issue_category');
         $res = $api->update(1, [
             'name' => 'new category name',

tests/Integration/IssueXmlTest.php

@@ -21,6 +21,7 @@ public function setup(): void
 
     public function testCreateBlank()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $this->assertInstanceOf('Redmine\Api\Issue', $api);
 
@@ -34,6 +35,7 @@ public function testCreateBlank()
 
     public function testCreateComplexWithUpload()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $res = $api->create([
             'project_id' => 'myproject',
@@ -69,6 +71,7 @@ public function testCreateComplexWithUpload()
 
     public function testCreateComplex()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $res = $api->create([
             'project_id' => 'test',
@@ -113,6 +116,7 @@ public function testCreateComplex()
 
     public function testCreateComplexWithLineBreakInDescription()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $res = $api->create([
             'project_id' => 'test',
@@ -158,6 +162,7 @@ public function testCreateComplexWithLineBreakInDescription()
 
     public function testUpdateIssue()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $res = $api->update(1, [
             'subject' => 'test note (xml) 1',
@@ -187,6 +192,7 @@ public function testUpdateIssue()
 
     public function testAddNoteToIssue()
     {
+        /** @var \Redmine\Api\Issue */
         $api = $this->client->getApi('issue');
         $res = $api->addNoteToIssue(1, 'some comment');
         $res = json_decode($res, true);

tests/Integration/MembershipXmlTest.php

@@ -22,6 +22,7 @@ public function setup(): void
 
     public function testCreateBlank()
     {
+        /** @var \Redmine\Api\Membership */
         $api = $this->client->getApi('membership');
         $this->assertInstanceOf('Redmine\Api\Membership', $api);
 
@@ -33,6 +34,7 @@ public function testCreateBlank()
 
     public function testCreateComplex()
     {
+        /** @var \Redmine\Api\Membership */
         $api = $this->client->getApi('membership');
         $res = $api->create('otherProject', [
             'user_id' => 1,
@@ -53,6 +55,7 @@ public function testCreateComplex()
 
     public function testUpdate()
     {
+        /** @var \Redmine\Api\Membership */
         $api = $this->client->getApi('membership');
         $res = $api->update(1, [
             'role_ids' => [1, 2],

tests/Integration/ProjectXmlTest.php

@@ -22,6 +22,7 @@ public function setup(): void
 
     public function testCreateBlank()
     {
+        /** @var \Redmine\Api\Project */
         $api = $this->client->getApi('project');
         $this->assertInstanceOf('Redmine\Api\Project', $api);
 
@@ -33,6 +34,7 @@ public function testCreateBlank()
 
     public function testCreateComplex()
     {
+        /** @var \Redmine\Api\Project */
         $api = $this->client->getApi('project');
         $res = $api->create([
             'name' => 'some name',
@@ -67,6 +69,7 @@ public function testCreateComplex()
 
     public function testCreateComplexWithTrackerIds()
     {
+        /** @var \Redmine\Api\Project */
         $api = $this->client->getApi('project');
         $res = $api->create([
             'name' => 'some name',
@@ -92,6 +95,7 @@ public function testCreateComplexWithTrackerIds()
 
     public function testUpdate()
     {
+        /** @var \Redmine\Api\Project */
         $api = $this->client->getApi('project');
         $res = $api->update(1, [
             'name' => 'different name',