Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan #326

Merged
merged 12 commits into from
Sep 22, 2023
Merged

Add phpstan #326

merged 12 commits into from
Sep 22, 2023

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Sep 21, 2023

This PR installs the static code analyser PHPStan and fixes all errors to level 4.

PHPStan will be run on Github Actions and can manually run by composer run phpstan.

@Art4 Art4 marked this pull request as draft September 21, 2023 10:52
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.79% 🎉

Comparison is base (3e2dcb2) 93.17% compared to head (0c91f76) 93.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x     #326      +/-   ##
============================================
+ Coverage     93.17%   93.97%   +0.79%     
  Complexity      362      362              
============================================
  Files            27       27              
  Lines          1128     1128              
============================================
+ Hits           1051     1060       +9     
+ Misses           77       68       -9     
Files Changed Coverage Δ
src/Redmine/Api/Group.php 100.00% <ø> (ø)
src/Redmine/Api/Issue.php 100.00% <ø> (ø)
src/Redmine/Api/Project.php 90.90% <ø> (ø)
src/Redmine/Api/Membership.php 100.00% <100.00%> (+24.32%) ⬆️
src/Redmine/Client/NativeCurlClient.php 90.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ awesome!

@Art4 Art4 marked this pull request as ready for review September 22, 2023 09:08
@Art4 Art4 merged commit 8665629 into kbsali:v2.x Sep 22, 2023
7 checks passed
@Art4 Art4 deleted the add-phpstan branch October 9, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants