Restore BC in all() methods with empty Redmine response

src/Redmine/Api/AbstractApi.php

@@ -4,6 +4,7 @@
 
 use Redmine\Api;
 use Redmine\Client\Client;
+use Redmine\Exception;
 use Redmine\Exception\SerializerException;
 use Redmine\Serializer\JsonSerializer;
 use Redmine\Serializer\PathSerializer;
@@ -169,16 +170,20 @@ protected function sanitizeParams(array $defaults, array $params)
      * @param string $endpoint API end point
      * @param array  $params   optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array|false elements found
+     * @return array|string|false elements found or error message or false
      */
     protected function retrieveAll($endpoint, array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.2.0, use `retrieveData()` instead.', E_USER_DEPRECATED);
 
         try {
             $data = $this->retrieveData(strval($endpoint), $params);
-        } catch (SerializerException $e) {
-            $data = false;
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
         }
 
         return $data;
@@ -307,6 +312,7 @@ protected function attachCustomFieldXML(SimpleXMLElement $xml, array $fields)
     private function getLastResponseBodyAsArray(): array
     {
         $body = $this->client->getLastResponseBody();
+
         $contentType = $this->client->getLastResponseContentType();
         $returnData = null;
 

src/Redmine/Api/CustomField.php

@@ -2,6 +2,9 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
+use Redmine\Exception\SerializerException;
+
 /**
  * Listing custom fields.
  *
@@ -20,6 +23,8 @@ class CustomField extends AbstractApi
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of custom fields found
      */
     final public function list(array $params = []): array
@@ -38,13 +43,21 @@ final public function list(array $params = []): array
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of custom fields found
+     * @return array|string|false list of custom fields found or error message or false
      */
     public function all(array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::list()` instead.', E_USER_DEPRECATED);
 
-        return $this->list($params);
+        try {
+            return $this->list($params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**

src/Redmine/Api/Group.php

@@ -2,8 +2,9 @@
 
 namespace Redmine\Api;
 
-use Exception;
+use Redmine\Exception;
 use Redmine\Exception\MissingParameterException;
+use Redmine\Exception\SerializerException;
 use Redmine\Serializer\PathSerializer;
 use Redmine\Serializer\XmlSerializer;
 
@@ -25,6 +26,8 @@ class Group extends AbstractApi
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of groups found
      */
     final public function list(array $params = []): array
@@ -43,13 +46,21 @@ final public function list(array $params = []): array
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of groups found
+     * @return array|string|false list of groups found or error message or false
      */
     public function all(array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::list()` instead.', E_USER_DEPRECATED);
 
-        return $this->list($params);
+        try {
+            return $this->list($params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**
@@ -114,7 +125,7 @@ public function create(array $params = [])
      */
     public function update($id, array $params = [])
     {
-        throw new Exception('Not implemented');
+        throw new \Exception('Not implemented');
     }
 
     /**

src/Redmine/Api/Issue.php

@@ -2,6 +2,8 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
+use Redmine\Exception\SerializerException;
 use Redmine\Serializer\JsonSerializer;
 use Redmine\Serializer\PathSerializer;
 use Redmine\Serializer\XmlSerializer;
@@ -38,6 +40,8 @@ class Issue extends AbstractApi
      *
      * @param array $params the additional parameters (cf available $params above)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of issues found
      */
     final public function list(array $params = []): array
@@ -64,13 +68,21 @@ final public function list(array $params = []): array
      *
      * @param array $params the additional parameters (cf available $params above)
      *
-     * @return array list of issues found
+     * @return array|string|false list of issues found or error message or false
      */
     public function all(array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::list()` instead.', E_USER_DEPRECATED);
 
-        return $this->list($params);
+        try {
+            return $this->list($params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**

src/Redmine/Api/IssueCategory.php

@@ -2,8 +2,10 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
 use Redmine\Exception\InvalidParameterException;
 use Redmine\Exception\MissingParameterException;
+use Redmine\Exception\SerializerException;
 use Redmine\Serializer\PathSerializer;
 use Redmine\Serializer\XmlSerializer;
 
@@ -27,6 +29,7 @@ class IssueCategory extends AbstractApi
      * @param array      $params            optional parameters to be passed to the api (offset, limit, ...)
      *
      * @throws InvalidParameterException if $projectIdentifier is not of type int or string
+     * @throws SerializerException if response body could not be converted into array
      *
      * @return array list of issue categories found
      */
@@ -54,13 +57,21 @@ final public function listByProject($projectIdentifier, array $params = []): arr
      * @param string|int $project project id or literal identifier
      * @param array      $params  optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of issue categories found
+     * @return array|string|false list of issue categories found or error message or false
      */
     public function all($project, array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::listByProject()` instead.', E_USER_DEPRECATED);
 
-        return $this->listByProject(strval($project), $params);
+        try {
+            return $this->listByProject(strval($project), $params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**

src/Redmine/Api/IssuePriority.php

@@ -2,6 +2,9 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
+use Redmine\Exception\SerializerException;
+
 /**
  * Listing issue priorities.
  *
@@ -20,6 +23,8 @@ class IssuePriority extends AbstractApi
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of issue priorities found
      */
     final public function list(array $params = []): array
@@ -38,12 +43,20 @@ final public function list(array $params = []): array
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of issue priorities found
+     * @return array|string|false list of issue priorities found or error message or false
      */
     public function all(array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::list()` instead.', E_USER_DEPRECATED);
 
-        return $this->list($params);
+        try {
+            return $this->list($params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 }

src/Redmine/Api/IssueRelation.php

@@ -2,6 +2,8 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
+use Redmine\Exception\SerializerException;
 use Redmine\Serializer\JsonSerializer;
 
 /**
@@ -23,6 +25,8 @@ class IssueRelation extends AbstractApi
      * @param int   $issueId the issue id
      * @param array $params  optional parameters to be passed to the api (offset, limit, ...)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of relations found
      */
     final public function listByIssueId(int $issueId, array $params = []): array
@@ -42,13 +46,21 @@ final public function listByIssueId(int $issueId, array $params = []): array
      * @param int   $issueId the issue id
      * @param array $params  optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of relations found
+     * @return array|string|false list of relations found or error message or false
      */
     public function all($issueId, array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::listByIssueId()` instead.', E_USER_DEPRECATED);
 
-        return $this->listByIssueId($issueId, $params);
+        try {
+            return $this->listByIssueId($issueId, $params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**

src/Redmine/Api/IssueStatus.php

@@ -2,6 +2,9 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
+use Redmine\Exception\SerializerException;
+
 /**
  * Listing issue statuses.
  *
@@ -20,6 +23,8 @@ class IssueStatus extends AbstractApi
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
+     * @throws SerializerException if response body could not be converted into array
+     *
      * @return array list of issue statuses found
      */
     final public function list(array $params = []): array
@@ -38,13 +43,21 @@ final public function list(array $params = []): array
      *
      * @param array $params optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of issue statuses found
+     * @return array|string|false list of issue statuses found or error message or false
      */
     public function all(array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::list()` instead.', E_USER_DEPRECATED);
 
-        return $this->list($params);
+        try {
+            return $this->list($params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**

src/Redmine/Api/Membership.php

@@ -2,8 +2,10 @@
 
 namespace Redmine\Api;
 
+use Redmine\Exception;
 use Redmine\Exception\InvalidParameterException;
 use Redmine\Exception\MissingParameterException;
+use Redmine\Exception\SerializerException;
 use Redmine\Serializer\XmlSerializer;
 
 /**
@@ -26,6 +28,7 @@ class Membership extends AbstractApi
      * @param array      $params            optional parameters to be passed to the api (offset, limit, ...)
      *
      * @throws InvalidParameterException if $projectIdentifier is not of type int or string
+     * @throws SerializerException if response body could not be converted into array
      *
      * @return array list of memberships found
      */
@@ -53,13 +56,21 @@ final public function listByProject($projectIdentifier, array $params = []): arr
      * @param string|int $project project id or literal identifier
      * @param array      $params  optional parameters to be passed to the api (offset, limit, ...)
      *
-     * @return array list of memberships found
+     * @return array|string|false list of memberships found or error message or false
      */
     public function all($project, array $params = [])
     {
         @trigger_error('`'.__METHOD__.'()` is deprecated since v2.4.0, use `'.__CLASS__.'::listByProject()` instead.', E_USER_DEPRECATED);
 
-        return $this->listByProject(strval($project), $params);
+        try {
+            return $this->listByProject(strval($project), $params);
+        } catch (Exception $e) {
+            if ($this->client->getLastResponseBody() === '') {
+                return false;
+            }
+
+            return $e->getMessage();
+        }
     }
 
     /**