Add slider block and update event content type #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sneridagh @ericof @iFlameing Can we convert this to use plone.exportimport? I can't review a pull request that has 30k additions and subtractions in a single file in any useful way. The fact that there are so many changed lines has me concerned that this is changing more than we intended. |
|
Yes, this should be a new PR |
|
@davisagli I can guarantee that it only consist the slider and event changes. We have this much changes just of styling. when I save file my file is completely different than which is present here. That's why we have that much line changes. |
iFlameing
force-pushed
the
updated-event-add-slider
branch
from
0794c2f
to
6c76ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.