Fix border for last Teaser #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Jun 26, 2023
There was a problem hiding this comment.
@danalvrz I tested this by manually editing /example/teaser-block in the bfs site to add a button. It works in view mode, but I still see the border when editing. I'm not sure if that's important or not, since in general the vertical spacing is not accurate when editing. /cc @sneridagh
|
@davisagli I noticed that as well, and believe it is because some classes are not present in edit mode, for example |
|
Right, it depends on the classes added by the block wrapper, and we don't have that in edit mode. Okay for now. |
davisagli
approved these changes
Jun 26, 2023
sneridagh
approved these changes
Jun 28, 2023
sneridagh
added a commit
that referenced
this pull request
Jun 29, 2023
* main: Fix css of Table of Contents block (#35) (#120) Fix border for last Teaser (#117) Fix css of grid image block css (#114) Fix Separator margins (#118) Quick CSS fix for introduction in view mode In-grid Image styles update (#111) Update in-grid slate styles (#110) Add rules and modify a few (#109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To comply with the Vertical Spacing rule for the last Teaser