Skip to content

Commit

Permalink
Fix registering of social blocks into volto-accordion (#31)
Browse files Browse the repository at this point in the history
* Fix registering of social blocks into volto-accordion (Fixes #30)

* Fix changelog.yml
  • Loading branch information
ericof authored Mar 22, 2024
1 parent c5191da commit eadbf81
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ jobs:
# compare the current branch with the base branch.
# Source: https://github.com/actions/checkout/#fetch-all-branches.
git fetch --no-tags origin ${BASE_BRANCH}
cd packages/${ADDON_NAME}
towncrier check --compare-with origin/${BASE_BRANCH}
towncrier check --dir packages/${ADDON_NAME}
env:
BASE_BRANCH: ${{ github.base_ref }}
if: github.event_name == 'pull_request'
1 change: 1 addition & 0 deletions packages/volto-social-blocks/news/30.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix registering of social blocks into volto-accordion [@ericof]
2 changes: 1 addition & 1 deletion packages/volto-social-blocks/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const applyConfig = (config) => {
// the internal `blocksConfig` object, so we clone the object to avoid this.
['__grid', 'gridBlock', 'accordion'].forEach((blockId) => {
const block = config.blocks.blocksConfig[blockId];
if (block !== undefined) {
if (block !== undefined && blocks.allowedBlocks !== undefined) {
const localBlocks = [
'facebookBlock',
'flickr',
Expand Down

0 comments on commit eadbf81

Please sign in to comment.