fix: don't interleave groups (#188)

kixelated · Sep 27, 2024 · ab0f36f · ab0f36f
1 parent 97f2799
commit ab0f36f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/moq-sub/src/media.rs b/moq-sub/src/media.rs
@@ -122,11 +122,9 @@ impl<O: AsyncWrite + Send + Unpin + 'static> Media<O> {
 		if let TrackReaderMode::Groups(mut groups) = track.mode().await? {
 			while let Some(group) = groups.next().await? {
 				let out = out.clone();
-				tokio::task::spawn(async move {
-					if let Err(err) = Self::recv_group(group, out).await {
-						warn!("failed to receive group: {err:?}");
-					}
-				});
+				if let Err(err) = Self::recv_group(group, out).await {
+					warn!("failed to receive group: {err:?}");
+				}
 			}
 		}
 		debug!("track {name}: finish");
@@ -140,7 +138,6 @@ impl<O: AsyncWrite + Send + Unpin + 'static> Media<O> {
 			let out = out.clone();
 			let buf = Self::recv_object(object).await?;
 
-			// TODO: avoid interleaving out of order fragments
 			out.lock().await.write_all(&buf).await?;
 		}