Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace knative.dev/client references to knative.dev/client-pkg #277

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Apr 9, 2023

Changes

  • 🧹 Replace knative.dev/client references to knative.dev/client-pkg

/kind cleanup

Part of knative/client#1591

Release Note


Docs


@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #277 (7e1e6cc) into main (2f84918) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files          24       24           
  Lines        1459     1459           
=======================================
  Hits         1152     1152           
  Misses        245      245           
  Partials       62       62           
Impacted Files Coverage Δ
pkg/command/autoscaling/list.go 91.17% <ø> (ø)
pkg/command/autoscaling/update.go 67.83% <ø> (ø)
pkg/command/cdc/list.go 92.68% <ø> (ø)
pkg/command/domain/human_readable_flags.go 100.00% <ø> (ø)
pkg/command/domain/list.go 82.85% <ø> (ø)
pkg/command/registry/add.go 91.58% <ø> (ø)
pkg/command/registry/human_readable_flags.go 87.23% <ø> (ø)
pkg/command/registry/list.go 87.01% <ø> (ø)
pkg/command/registry/remove.go 75.22% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vyasgun vyasgun force-pushed the pr/client-pkg branch 2 times, most recently from 7362f2b to f58a3de Compare April 9, 2023 14:22
@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 9, 2023

/retest

@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 14, 2023

/retest

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@knative-prow knative-prow bot merged commit a9dce0e into knative-extensions:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants