Bump Istio and simplify update script #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XXL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
+ Coverage 82.25% 82.37% +0.11%
==========================================
Files 26 26
Lines 1668 1668
==========================================
+ Hits 1372 1374 +2
+ Misses 195 194 -1
+ Partials 101 100 -1 ☔ View full report in Codecov by Sentry. |
dprotaso
force-pushed
the
bump-istio-1.22.2
branch
2 times, most recently
from
b032588
to
56ba229
Compare
Now we just need to bump a number in ./hack/update-dep.sh then run the script to update our golang dependencies and the generated manifests Also it seems like the `istio generate manifest` command outputs stable documents so we don't need our sorting logic anymore
dprotaso
force-pushed
the
bump-istio-1.22.2
branch
from
56ba229
to
25ed8f4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we just need to bump a number in ./hack/update-dep.sh
then run the script to update our golang dependencies
and the generated manifests
Also it seems like the
istio generate manifestcommandoutputs stable documents so we don't need our sorting logic
anymore