-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move code being used by kafka plugin from client #67
Conversation
Codecov ReportBase: 78.24% // Head: 81.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 78.24% 81.47% +3.22%
==========================================
Files 13 24 +11
Lines 832 1684 +852
==========================================
+ Hits 651 1372 +721
- Misses 141 239 +98
- Partials 40 73 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
// +genclient:noStatus | ||
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to bring in hack/update-codege.sh
script as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will copy the scripts for this.
/test all |
pkg/kn/plugin/manager.go
Outdated
// Allow plugins to register to this slice for inlining | ||
var InternalPlugins PluginList | ||
|
||
// Interface describing a plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the plugin purposes we should only extract this interface from the knative/client, maybe move it to types.go
file and keep manager.go in tact in current repository. The interface is actually only common code for plugins to use.
b1e03ba
to
d6b2de6
Compare
d6b2de6
to
e7cdee7
Compare
// Allow plugins to register to this slice for inlining | ||
var InternalPlugins PluginList | ||
|
||
// Interface describing a plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep only Plugin
interface. Both PluginList []Plugin
and var InternalPlugins PluginList
is needed only on the knative/client
side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InternalPlugins is being used in the kafka-plugin:
https://github.com/knative-sandbox/kn-plugin-source-kafka/blob/main/plugin/plugin.go#L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok, that's the part of plugin registering to kn
. Sure then we need it here.
lib/test/cli.go
Outdated
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the lib/
top-level dir completely. Maybe move to pkg/util/test
package or just pkg/util.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved lib/
to pkg/util
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind enhancement
Fixes partly knative/client#1591
Release Note
Docs