Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move code being used by func from client #79

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Move code being used by func from client #79

merged 2 commits into from
Jan 16, 2023

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Dec 6, 2022

Changes

  • 🎁 Moved shared code for kafka plugin from client

/kind enhancement

Fixes partly knative/client#1591

Release Note

Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Base: 81.03% // Head: 81.03% // No change to project coverage 👍

Coverage data is based on head (8c4e805) compared to base (6a21123).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          65       65           
  Lines        5241     5241           
=======================================
  Hits         4247     4247           
  Misses        766      766           
  Partials      228      228

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dsimansk
dsimansk reviewed Dec 7, 2022
View reviewed changes
pkg/util/lib/test/capture_output.go Outdated
@@ -0,0 +1,77 @@
// Copyright 2020 The Knative Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bottom line note: I'd get rid of lib directory for the rest of test package files. E.g. to have pkg/util/test/... path.

@dsimansk
Copy link
Contributor

dsimansk commented Dec 7, 2022

/approve
/lgtm

For the comment on the review. It can be addressed in a follow-up PR or here.
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2023
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@knative-prow knative-prow bot merged commit 6ff9141 into knative:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk left review comments

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasgun @dsimansk