Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved code for kamelet plugin #84

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jan 25, 2023

Changes

  • Moved the files that were being used in kamelet plugin

/kind cleanup

Part of knative/client#1591

Release Note


Docs


@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 25, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 81.03% // Head: 80.96% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (07c0aa2) compared to base (d4ab4e4).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   81.03%   80.96%   -0.08%     
==========================================
  Files          65       67       +2     
  Lines        5241     5326      +85     
==========================================
+ Hits         4247     4312      +65     
- Misses        766      782      +16     
- Partials      228      232       +4     
Impacted Files Coverage Δ
pkg/kn/commands/flags/listprint.go 70.00% <70.00%> (ø)
pkg/kn/commands/human_readable_flags.go 82.22% <82.22%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasgun vyasgun changed the title Moved code form kamelet plugin Moved code for kamelet plugin Jan 25, 2023
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fb6e402 into knative:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants