fix live preview

[shivamgupta2020]

This PR resolve live preview that is currently not working properly.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivamgupta2020
Once this PR has been reviewed and has the lgtm label, please assign zainabhusain227 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	55f1ace
🔍 Latest deploy log	https://app.netlify.com/sites/knative/deploys/6668bbc2465688000910d9b3
😎 Deploy Preview	https://deploy-preview-6013--knative.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[shivamgupta2020]

/cc @Cali0707

[Cali0707]

/cc @Leo6Leo
Can you TAL when you have a chance?

[Leo6Leo]

@shivamgupta2020 @Cali0707 Can you provide me with more context about this PR? Is it trying to solve these failures of github actions?

Without the changes in this PR, the compilation works fine on my sample app PR and locally. Not sure what is the issue with live preview. If clarification can be provided, that would be really appretiated.

[Cali0707]

@Leo6Leo this is to fix the live preview reloading for all the pages, it seems like it currently does not work for pages in the blog directory

[shivamgupta2020]

@Leo6Leo , currently the website doesn't reload when changes are made. We have to run ./hack/docker/run.sh or mkdocs serve each time to view changes. This PR fixes live preview reloading, so the website automatically reloads when changes are made.

[Leo6Leo]

Please see the comment. Nice catch! @shivamgupta2020

[Leo6Leo]

Removing --dirtyreload will result in rebuilding the whole sites when you are making changes to .md files. That makes it really non-efficient. You can see the distinct time difference with --dirtyreload and without --dirtyreload.

According to the doc here:

This mode simply compares the modified time of the generated HTML and source markdown. If the markdown has changed since the HTML then the page is re-constructed. Otherwise, the page remains as is.

https://www.mkdocs.org/about/release-notes/#support-for-dirty-builds-990

I see the problem that when you are making changes to the file in /overrides, the pages will not be updated unless you manually re-run the ./hack/docker/run.sh. I would suggest you to find another solution to resolve this issue. @shivamgupta2020

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.