Update golang images in code samples #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XL
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
skonto
commented
Sep 16, 2024
| @@ -1,6 +1,6 @@ | |||
| # Use the official Haskell image to create a build artifact. | |||
| # https://hub.docker.com/_/haskell/ | |||
| FROM haskell:8.2.2 as builder | |||
| FROM haskell:8.2.2 AS builder | |||
There was a problem hiding this comment.
s/as/AS otherwise a warning is emitted.
skonto
commented
Sep 16, 2024
|
|
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
| # Create and change to the app directory. | ||
| WORKDIR /app | ||
|
|
||
| # Initialize the Go module inside the Dockerfile. | ||
| RUN go mod init mymodule |
There was a problem hiding this comment.
removing this as we copy the go.mod file (same approach in other files).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6110
Proposed Changes