fix runtime image probe handler setup

[dprotaso]

While working on knative-extensions/net-gateway-api#18

I discovered the runtime image in this repository doesn't behave like the queue proxy. The probe handler should work with any URL path but this image it only works when the path is /healthz

The change in the PR changes the handler setup so the probe handler is first. This is what the other networking images do.

/assign @izabelacg

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

cc @ReToCode @skonto

[izabelacg]

can you share how to reproduce the issue? I curled the service (original) in different paths with the user-agent header and seems to work as expected. I get the following:

$ curl http://runtime-test-image.default.svc.cluster.local -H "User-Agent: kube-probe/1.25" -v
* Host runtime-test-image.default.svc.cluster.local:80 was resolved.r-Agent: kube-probe/1.25" -v
...
* Connected to runtime-test-image.default.svc.cluster.local (10.96.102.30) port 80
> GET / HTTP/1.1
> Host: runtime-test-image.default.svc.cluster.local
> Accept: */*
> User-Agent: kube-probe/1.25
> 
* Request completely sent off
< HTTP/1.1 200 OK
< date: Wed, 10 Apr 2024 18:08:21 GMT
< content-length: 0
< x-envoy-upstream-service-time: 0
< server: envoy
< 
* Connection #0 to host runtime-test-image.default.svc.cluster.local left intact

[dprotaso]

When you curl with the probe header it should always return the hash

eg.

curl -vv -H"K-Network-Hash: some-hash" -H"K-Network-Probe: probe" localhost:8080/healthz

Should also work when you are not using the /healthz path

curl -vv -H"K-Network-Hash: some-hash" -H"K-Network-Probe: probe" localhost:8080

[dprotaso]

If you're running this image with Knative Service then you won't reproduce original issue

These pods don't run with the queue proxy sidecar in the conformance tests - so it's replicating that.

[izabelacg]

Thanks for the explanation. I got to see the issue and solution working.

[izabelacg]

/lgtm