Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial README #4

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Initial README #4

merged 1 commit into from
Nov 30, 2019

Conversation

ligi
Copy link
Member

@ligi ligi commented Nov 28, 2019

No description provided.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I'm late to the game with this question, why not use bivrost plugin?

https://github.com/gnosis/bivrost-kotlin

@ligi
Copy link
Member Author

ligi commented Nov 28, 2019

e.g. because of this:

@mirceanis
Copy link
Member

Correct, but I think it is worth fixing that with a PR, rather than a new lib.
Of course, multiple alternatives to solve a problem are good, so I would welcome an addition to the komputing space.
I'm asking out of a concern about the maintenance overhead.

@ligi
Copy link
Member Author

ligi commented Nov 28, 2019

Yea - I was considering doing it as a PR to bivrost-kotlin. An if the android coupling would have been the only thing this would have been the way to go most likely. But another big topic was the type system - I needed something that worked with kethereum types (e.g. address) - and changing this in bivrost would have been ugly and perhaps not even merged upstream. Also please have a look at both codebases. I think kethabi turned out quite nice so I do not regret the decision. Also happy to take on the maintenance overhead in this case.

@ligi ligi merged commit e850300 into master Nov 30, 2019
@ligi ligi deleted the ligi-patch-1 branch November 30, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants