Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RELEASE-927): add e2e tests for multi-arch #1230

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(RELEASE-927): add e2e tests for multi-arch #1230

wants to merge 1 commit into from
+498 −0

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Jun 25, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jinqi7. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 26, 2024
View reviewed changes
magefiles/magefile.go Outdated
return fmt.Errorf("error when building/pushing a tekton pipeline bundle: %v", err)
}
klog.Infof("SETTING ENV VAR %s to value %s\n", constants.CUSTOM_MULTI_ARCH_PIPELINE_BUILD_BUNDLE_ENV, newRemotePipeline.String())
os.Setenv(constants.CUSTOM_MULTI_ARCH_PIPELINE_BUILD_BUNDLE_ENV, newRemotePipeline.String())

Check warning

Code scanning / gosec

Errors unhandled.

Errors unhandled.
@kasemAlem @dheerajodha
@psturc @jinqi7
feat(STONEINTG-937): add nightly Gitlab webhooks cleanup (konflux-ci#…
661d8c2 
…1216)

* feat(STONEINTG-937): add nightly Gitlab webhooks cleanup

Signed-off-by: Kasem Alem <[email protected]>

* chore(STONEINTG-937): improve function names and comments

Signed-off-by: Dheeraj<[email protected]>

* fix: list all gitlab hooks

---------

Signed-off-by: Kasem Alem <[email protected]>
Signed-off-by: Dheeraj<[email protected]>
Co-authored-by: Dheeraj Singh Jodha <[email protected]>
Co-authored-by: Pavel Sturc <[email protected]>
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10-15 min do-not-merge/work-in-progress needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinqi7 @openshift-merge-robot @kasemAlem