feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal #1262

jinqi7 · 2024-07-15T09:46:14Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
I have updated labels (if needed)

openshift-ci · 2024-07-15T09:46:19Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2024-07-15T10:36:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jinqi7. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tests/release/const.go

jinqi7 · 2024-07-16T12:45:20Z

/test all

jinqi7 · 2024-07-22T01:10:04Z

/test redhat-appstudio-e2e

jinqi7 · 2024-07-29T10:17:55Z

/test redhat-appstudio-e2e

tests/release/const.go

pkg/constants/constants.go

tests/release/const.go

tests/release/pipelines/push_binaries_to_dev_portal.go

johnbieren · 2024-07-30T17:01:58Z

tests/release/pipelines/push_binaries_to_dev_portal.go

+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			It("verifies release CR completed and set succeeded.", func() {


We should probably talk about if there is another check we can do for success in addition to the release CR succeeding (like we do in many other tests)

I asked developers if more checks are needed and didn't get a suggestion. Maybe add some checks about the message in the log of the tasks?

If it is a slack thread, can you send it to me? It isn't always possible, but I think it is much better when we have some test specific check after the release pipelineRun to ensure what we expected to happen actually happened and we didn't just hit some exit 0 edge case early in the run

It's in this thread. Anyway, I added some check about the output from some important action in the "publish-to-cgw" task and will add similar check from "push-to-cdn" when can it run successfully.

Hmm, that link doesn't work for me

tests/release/const.go

johnbieren · 2024-07-31T15:01:30Z

@jinqi7 based on discussions on slack today, maybe this should be moved to draft until we figure out the push-to-cdn thing

jinqi7 · 2024-08-02T08:59:42Z

/test redhat-appstudio-e2e

magefiles/magefile.go

johnbieren · 2024-08-06T17:25:15Z

tests/release/pipelines/push_binaries_to_dev_portal.go

+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			It("verifies release CR completed and set succeeded.", func() {


Hmm, that link doesn't work for me

jinqi7 · 2024-08-12T06:30:01Z

/retest

Signed-off-by: Jing Qi <[email protected]>

jinqi7 · 2024-08-12T12:37:51Z

/retest

jinqi7 · 2024-08-12T14:01:21Z

/retest

konflux-ci-qe-bot · 2024-08-12T15:22:54Z

@jinqi7: The following test finished. In case the test failed, say /retest to rerun all failed tests:

PipelineRun name	Revision	PipelineRun Status	Command
konflux-e2e-86sv9-2d4l8	`6f568a4`	Failed	/retest

To inspect your test artifacts, ensure you have installed ORAS on your local machine. To inspect all test artifacts, execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-86sv9-2d4l8

For instructions on how to install ORAS, please refer to the ORAS installation guide.

konflux-ci-qe-bot · 2024-08-12T15:23:02Z

@jinqi7: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name	Command
konflux-e2e-86sv9-2d4l8	/retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-86sv9-2d4l8

For instructions on how to install ORAS, please refer to the ORAS installation guide.

openshift-ci bot added the do-not-merge/work-in-progress label Jul 15, 2024

github-actions bot added the 5-10 min label Jul 15, 2024

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 3a73a5d to 02e76cf Compare July 15, 2024 10:36

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 02e76cf to 5841896 Compare July 15, 2024 11:38

github-advanced-security bot found potential problems Jul 15, 2024

View reviewed changes

tests/release/const.go Fixed Show fixed Hide fixed

jinqi7 force-pushed the push-binaries-to-dev-portal branch 3 times, most recently from 842de49 to c370fb2 Compare July 16, 2024 03:32

github-advanced-security bot found potential problems Jul 16, 2024

View reviewed changes

tests/release/const.go Fixed Show fixed Hide fixed

jinqi7 force-pushed the push-binaries-to-dev-portal branch from c370fb2 to 8831f0a Compare July 25, 2024 09:27

openshift-merge-robot added the needs-rebase label Jul 25, 2024

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 8831f0a to 90c109f Compare July 29, 2024 10:17

openshift-merge-robot removed the needs-rebase label Jul 29, 2024

github-advanced-security bot found potential problems Jul 29, 2024

View reviewed changes

tests/release/const.go Fixed Show fixed Hide fixed

tests/release/const.go Fixed Show fixed Hide fixed

jinqi7 marked this pull request as ready for review July 30, 2024 01:13

openshift-ci bot removed the do-not-merge/work-in-progress label Jul 30, 2024

openshift-ci bot requested review from johnbieren and mmalina July 30, 2024 01:14

jinqi7 requested a review from a team July 30, 2024 01:14

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 90c109f to 2630658 Compare July 30, 2024 01:16

johnbieren reviewed Jul 30, 2024

View reviewed changes

jinqi7 force-pushed the push-binaries-to-dev-portal branch 3 times, most recently from 01a9bfd to ba45a4a Compare July 31, 2024 08:36

github-advanced-security bot found potential problems Jul 31, 2024

View reviewed changes

tests/release/const.go Dismissed Show dismissed Hide dismissed

tests/release/const.go Dismissed Show dismissed Hide dismissed

jinqi7 marked this pull request as draft August 1, 2024 05:22

openshift-ci bot added the do-not-merge/work-in-progress label Aug 1, 2024

jinqi7 force-pushed the push-binaries-to-dev-portal branch from ba45a4a to 8e0832f Compare August 2, 2024 08:58

johnbieren reviewed Aug 6, 2024

View reviewed changes

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 8e0832f to 052135e Compare August 7, 2024 10:52

feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal

6f568a4

Signed-off-by: Jing Qi <[email protected]>

jinqi7 force-pushed the push-binaries-to-dev-portal branch from 052135e to 6f568a4 Compare August 12, 2024 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal #1262

feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal #1262

jinqi7 commented Jul 15, 2024

openshift-ci bot commented Jul 15, 2024

openshift-ci bot commented Jul 15, 2024

jinqi7 commented Jul 16, 2024

jinqi7 commented Jul 22, 2024

jinqi7 commented Jul 29, 2024

johnbieren Jul 30, 2024

jinqi7 Jul 31, 2024

johnbieren Jul 31, 2024

jinqi7 Aug 1, 2024

johnbieren Aug 6, 2024

johnbieren commented Jul 31, 2024

jinqi7 commented Aug 2, 2024

johnbieren Aug 6, 2024

jinqi7 commented Aug 12, 2024

jinqi7 commented Aug 12, 2024

jinqi7 commented Aug 12, 2024

konflux-ci-qe-bot commented Aug 12, 2024

konflux-ci-qe-bot commented Aug 12, 2024

feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal #1262

Are you sure you want to change the base?

feat(RELEASE-983): add e2e tests for push-binaries-to-dev-portal #1262

Conversation

jinqi7 commented Jul 15, 2024

Description

Issue ticket number and link

Type of change

How Has This Been Tested?

Checklist:

openshift-ci bot commented Jul 15, 2024

openshift-ci bot commented Jul 15, 2024

jinqi7 commented Jul 16, 2024

jinqi7 commented Jul 22, 2024

jinqi7 commented Jul 29, 2024

johnbieren Jul 30, 2024

Choose a reason for hiding this comment

jinqi7 Jul 31, 2024

Choose a reason for hiding this comment

johnbieren Jul 31, 2024

Choose a reason for hiding this comment

jinqi7 Aug 1, 2024

Choose a reason for hiding this comment

johnbieren Aug 6, 2024

Choose a reason for hiding this comment

johnbieren commented Jul 31, 2024

jinqi7 commented Aug 2, 2024

johnbieren Aug 6, 2024

Choose a reason for hiding this comment

jinqi7 commented Aug 12, 2024

jinqi7 commented Aug 12, 2024

jinqi7 commented Aug 12, 2024

konflux-ci-qe-bot commented Aug 12, 2024

konflux-ci-qe-bot commented Aug 12, 2024