-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add libpfm4&perf group #1554
Conversation
cb88d52
to
6afb121
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 65.19% 65.72% +0.53%
==========================================
Files 352 376 +24
Lines 36326 39842 +3516
==========================================
+ Hits 23681 26186 +2505
- Misses 10901 11745 +844
- Partials 1744 1911 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cdd92e7
to
8c74079
Compare
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go
Show resolved
Hide resolved
Signed-off-by: bowen-intel <[email protected]>
af7b27f
to
c4e3a75
Compare
Signed-off-by: bowen-intel <[email protected]>
Make a A/B test for two method: workload100 nginx apiVersion: apps/v1
kind: Deployment
metadata:
name: my-nginx
namespace: nginx
labels:
run: my-nginx
spec:
replicas: 100
selector:
matchLabels:
run: my-nginx
template:
metadata:
labels:
run: my-nginx
spec:
nodeName: inspur-icx-1
containers:
- name: my-nginx
image: nginx:latest
ports:
- containerPort: 80
resources:
requests:
cpu: "1"
memory: 1Gi
limits:
cpu: "1"
memory: 1Gi
---
apiVersion: v1
kind: Service
metadata:
name: my-nginx
namespace: nginx
labels:
run: my-nginx
spec:
ports:
- port: 80
protocol: TCP
targetPort: 80
selector:
run: my-nginx environmentCPU Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz libpfm4perf-util |
Any comments and questions is welcome! 😀 @zwzhang0107 @songtao98 |
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: bowen-intel <[email protected]>
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go
Show resolved
Hide resolved
this looks great! it will be better if we have the comparison on accuracy between perf and libpfm4 |
Signed-off-by: bowen-intel <[email protected]>
Signed-off-by: bowen-intel <[email protected]>
Signed-off-by: bowen-intel <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bowen-intel <[email protected]>
Signed-off-by: bowen-intel <[email protected]>
Ⅰ. Describe what this PR does
This pull request enhances the precision of CPI calculation through the utilization of the perf group. Additionally, it introduces the integration of libpfm4 as an event parser, thereby expanding the potential to incorporate additional TMA analyses in subsequent developments.
Ⅱ. Does this pull request fix one issue?
fixes #1476 #1470
Ⅲ. Describe how to verify it
Use Prometheus.
Ⅳ. Special notes for reviews
This pr uses
unsafe.Pointer
to mocksyscall.Syscall6
in unit test, so I have to add unsafeptr tag forgo vet
tool and ignoregithub.com/koordinator-sh/koordinator/pkg/koordlet/util/perf
package in test since it use -race tag.Any comments is welcome.
V. Checklist
make test