koord-scheduler: ignore non-existing resources in NUMA Node #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 64.70% 64.84% +0.13%
==========================================
Files 361 361
Lines 37636 37648 +12
==========================================
+ Hits 24351 24411 +60
+ Misses 11493 11445 -48
Partials 1792 1792
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hormes
reviewed
Sep 4, 2023
eahydra
force-pushed
the
fix_numaaware_affinity_merge
branch
from
20eb1d1
to
945cfc1
Compare
Signed-off-by: Joseph <[email protected]>
eahydra
force-pushed
the
fix_numaaware_affinity_merge
branch
from
945cfc1
to
3a3610b
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…tor-sh#1607) Signed-off-by: Joseph <[email protected]>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…tor-sh#1607) Signed-off-by: Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
At present, koordlet only reports cpu/memory in NodeResourceTopology. If a Pod requests resources from other resources, the Pod will not be able to be scheduled. So we should skip these non-existing resources.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test