Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support devices of the same node gpuMem not equal #2199

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Sep 5, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2191

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (4f16162) to head (fca3ced).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...scheduler/plugins/deviceshare/devicehandler_gpu.go 92.30% 1 Missing and 1 partial ⚠️
pkg/scheduler/plugins/deviceshare/plugin.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   67.72%   67.72%   -0.01%     
==========================================
  Files         446      446              
  Lines       42697    42705       +8     
==========================================
+ Hits        28918    28920       +2     
- Misses      11257    11261       +4     
- Partials     2522     2524       +2     
Flag Coverage Δ
unittests 67.72% <86.20%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

saintube commented Sep 5, 2024

/lgtm

@ZiMengSheng
Copy link
Contributor Author

/approve

@ZiMengSheng
Copy link
Contributor Author

/approve

@ZiMengSheng
Copy link
Contributor Author

/lgtm

1 similar comment
@saintube
Copy link
Member

/lgtm

@saintube saintube added the lgtm label Sep 14, 2024
@ZiMengSheng
Copy link
Contributor Author

/approve

@koordinator-bot koordinator-bot bot merged commit beab44e into koordinator-sh:main Sep 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants