Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: fix descheduler object limiter with multiple profiles #2200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

songtao98
Copy link
Contributor

Ⅰ. Describe what this PR does

koord-descheduler uses limiterMap to manage object limiters. If multiple profiles are configured, all MigrationControllers in all profiles can evict pods from all PodMigrationJobs. But a workload limiter may be recorded inside one limiterMap of a profile, but evicted by another limiterMap. This may cause object limiter not working.

This PR add a UUID to MigrationController and an Annotation to PodMigrationJob. Each time a PodMigrationJob is created by MigrationController, its UUID will be recorded into this Annotation. Each time a MigrationController from a profile reconciling a PodMigrationJob, it decide if to drop this PodMigraionJob by this annotation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@songtao98 songtao98 force-pushed the support_descheduler_multiple_profiles branch from 8a0c4bb to 39743f8 Compare September 9, 2024 03:04
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (aacf585) to head (39743f8).

Files with missing lines Patch % Lines
...kg/descheduler/controllers/migration/controller.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
- Coverage   67.72%   67.72%   -0.01%     
==========================================
  Files         446      446              
  Lines       42695    42699       +4     
==========================================
  Hits        28916    28916              
- Misses      11258    11259       +1     
- Partials     2521     2524       +3     
Flag Coverage Δ
unittests 67.72% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant