Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ws): remove unused libraries react-axe and react-docgen-typescript-loader #24

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Jul 16, 2024

Closes #25

Description

react-axe: help to fix and identify accessibility issues. The project was moved to another org so we will need to add them back later.
react-docgen-typescript-loader: it's not necessary. Leftover from the seed project

How Has This Been Tested?

➜  frontend git:(main) ✗ npm install                                                                                                                  (kind-kubebuilder-cluster/default)

up to date, audited 1199 packages in 720ms

210 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
➜  frontend git:(main) ✗ npm audit                                                                                                                    (kind-kubebuilder-cluster/default)
found 0 vulnerabilities

…ocgen-typescript-loader)

Signed-off-by: Eder Ignatowicz <[email protected]>
@thesuperzapper thesuperzapper added area/frontend area - related to frontend components project/notebooks-v2 project - kubeflow notebooks v2 labels Jul 18, 2024
@thesuperzapper thesuperzapper added this to the v2.0.0-alpha.0 milestone Jul 18, 2024
@thesuperzapper thesuperzapper changed the title chore: remove some unused deprecated libraries (react-axe and react-docgen-typescript-loader) chore(ws): remove unused libraries react-axe and react-docgen-typescript-loader Jul 18, 2024
@thesuperzapper
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 574ed81 into kubeflow:notebooks-v2 Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/frontend area - related to frontend components lgtm project/notebooks-v2 project - kubeflow notebooks v2 size/XXL
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ci(ws): Remove some unused deprecated libraries (react-axe and react-docgen-typescript-loader)
2 participants