Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iam doc #1350

Merged
merged 8 commits into from
Mar 2, 2023
Merged

Iam doc #1350

merged 8 commits into from
Mar 2, 2023

Conversation

vgramer
Copy link
Contributor

@vgramer vgramer commented Feb 8, 2023 •
edited
Loading

This PR

  • explain what KKP roles exactly allow
  • rename cluster-rbac page to cluster-access
  • rename role-based-access-control to iam-and-role-based-access-control for searchability
  • add a description of dex and most popular connectors for searchability

fix #1304

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2023
@vgramer vgramer requested a review from embik February 14, 2023 10:30
@embik
Copy link
Member

embik commented Feb 16, 2023

We also don't seem to explain what the KKP roles exactly allow, which I think was part of the ticket this PR should solve.

@csengerszabo
Copy link
Contributor

We also don't seem to explain what the KKP roles exactly allow, which I think was part of the ticket this PR should solve.

If you're referring to the KKP admin and KKP user roles, yes, I agree, we should describe them in a separate section in this chapter in a table with their privileges

@embik
Copy link
Member

embik commented Feb 16, 2023

We also don't seem to explain what the KKP roles exactly allow, which I think was part of the ticket this PR should solve.

If you're referring to the KKP admin and KKP user roles, yes, I agree, we should describe them in a separate section in this chapter in a table with their privileges

I saw that you opened another ticket related to that, #1362, so maybe it's out of scope for this PR.

@csengerszabo
Copy link
Contributor

We also don't seem to explain what the KKP roles exactly allow, which I think was part of the ticket this PR should solve.

If you're referring to the KKP admin and KKP user roles, yes, I agree, we should describe them in a separate section in this chapter in a table with their privileges

I saw that you opened another ticket related to that, #1362, so maybe it's out of scope for this PR.

The best would be if it was also included here. But that will need some work to list the priviliges. So up to @vgramer if he could include that, it would be highly appreciated

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2023
embik
embik requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes, but I wonder if this should be backported to the v2.22 docs content as well. @csengerszabo, WDYT?

content/kubermatic/main/architecture/iam-role-based-access-control/_index.en.md Outdated Show resolved Hide resolved
content/kubermatic/main/tutorials-howtos/cluster-accessibility/_index.en.md Outdated Show resolved Hide resolved
content/kubermatic/main/architecture/iam-role-based-access-control/_index.en.md Outdated Show resolved Hide resolved
vgramer and others added 4 commits February 28, 2023 14:53
@vgramer
Copy link
Contributor Author

vgramer commented Feb 28, 2023

I wonder if this should be backported to the v2.22 docs content as well. @csengerszabo

As discussed in the daily with @csengerszabo , i have backported doc to v2.22

@csengerszabo
Copy link
Contributor

Can we merge this? Do we have anything else to change? @embik @vgramer

@csengerszabo
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d29863a4d10add16705a7a8a6660b41435823a5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csengerszabo, vgramer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 780e142 into kubermatic:master Mar 2, 2023
@vgramer vgramer deleted the iam-doc branch March 2, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csengerszabo csengerszabo csengerszabo left review comments

@embik embik embik requested changes

Assignees

@embik embik

@csengerszabo csengerszabo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IAM policy structured documentation
4 participants
@vgramer @embik @csengerszabo @kubermatic-bot