Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a tutorial page for VPA in kkp #1750

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added a tutorial page for VPA in kkp #1750

wants to merge 3 commits into from
+259 −206

Conversation

dharapvj
Copy link
Contributor

Currently, VPA feature in KKP is not well documented. So this PR adds some initial documentation on how to make use of this feature.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2024
@dharapvj
Copy link
Contributor Author

CC: @toschneck - FYI

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dharapvj. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dharapvj dharapvj requested a review from xrstf September 26, 2024 07:06
xrstf
xrstf requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpickery

@dharapvj
Copy link
Contributor Author

dharapvj commented Oct 1, 2024

I have fixed those nits. please recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf requested changes

Assignees

@xrstf xrstf

Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dharapvj @kubermatic-bot @xrstf