Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image digest parsing #1612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwcesign
Copy link
Contributor

@jwcesign jwcesign commented Aug 30, 2024

Fixes #none

Description

When I do test with kind&kwok, it has the following error:

root@LAPTOP-7A2QVS89 [11:51:16] [~/git/karpenter] [fix-3]
-> # make apply
2024/08/30 11:54:35 Using base cgr.dev/chainguard/static:latest@sha256:791657dd88dea8c1f9d3779815429f9c681a9a2778fc66dac3fbf550e1f1d9c8 for [[sigs.k8s.io/karpenter/kwok](http://sigs.k8s.io/karpenter/kwok)](http://sigs.k8s.io/karpenter/kwok)
2024/08/30 11:54:49 git is in a dirty state
Please check in your pipeline what can be changing the following files:
M Makefile

2024/08/30 11:54:49 Building [[sigs.k8s.io/karpenter/kwok](http://sigs.k8s.io/karpenter/kwok)](http://sigs.k8s.io/karpenter/kwok) for linux/amd64
2024/08/30 11:54:51 Loading kind.local/kwok:f8ae62a6a7b702fe8fe39dd104dc8501367a89ba6bcd656a77a5b60384444fa6
2024/08/30 11:54:54 Loaded kind.local/kwok:f8ae62a6a7b702fe8fe39dd104dc8501367a89ba6bcd656a77a5b60384444fa6
2024/08/30 11:54:54 Adding tag latest
2024/08/30 11:54:54 Added tag latest
kubectl apply -f kwok/charts/crds
[[customresourcedefinition.apiextensions.k8s.io/kwoknodeclasses.karpenter.kwok.sh](http://customresourcedefinition.apiextensions.k8s.io/kwoknodeclasses.karpenter.kwok.sh)](http://customresourcedefinition.apiextensions.k8s.io/kwoknodeclasses.karpenter.kwok.sh) created
[[customresourcedefinition.apiextensions.k8s.io/nodeclaims.karpenter.sh](http://customresourcedefinition.apiextensions.k8s.io/nodeclaims.karpenter.sh)](http://customresourcedefinition.apiextensions.k8s.io/nodeclaims.karpenter.sh) created
[[customresourcedefinition.apiextensions.k8s.io/nodepools.karpenter.sh](http://customresourcedefinition.apiextensions.k8s.io/nodepools.karpenter.sh)](http://customresourcedefinition.apiextensions.k8s.io/nodepools.karpenter.sh) created
helm upgrade --install karpenter kwok/charts --namespace kube-system --skip-crds \
--set logLevel=debug --set controller.resources.requests.cpu=1 --set controller.resources.requests.memory=1Gi --set controller.resources.limits.cpu=1 --set controller.resources.limits.memory=1Gi \
--set controller.image.repository=kind.local/kwok \
--set controller.image.tag=f8ae62a6a7b702fe8fe39dd104dc8501367a89ba6bcd656a77a5b60384444fa6 \
--set controller.image.digest=kind.local/kwok:f8ae62a6a7b702fe8fe39dd104dc8501367a89ba6bcd656a77a5b60384444fa6 \
--set-string controller.env[0].name=ENABLE_PROFILING \
--set-string controller.env[0].value=true
Release "karpenter" does not exist. Installing it now.

The digest should be empty, but it parsed as kind.local/kwok:f8ae62a6a7b702fe8fe39dd104dc8501367a89ba6bcd656a77a5b60384444fa6.

How was this change tested?

make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jwcesign
Once this PR has been reviewed and has the lgtm label, please assign tzneal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jwcesign. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10627341597

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 80.733%

Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.01%
pkg/controllers/disruption/consolidation.go 4 87.25%
Totals Coverage Status
Change from base Build 10622339666: -0.02%
Covered Lines: 8389
Relevant Lines: 10391

💛 - Coveralls

Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2024
@jwcesign
Copy link
Contributor Author

cc @njtran

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
Copy link

github-actions bot commented Oct 3, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants