-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allows for image repos to be set via Environment Variables #2705
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @rackeric! |
Hi @rackeric. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rackeric The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6221176
to
9983076
Compare
- useful when using a mirrored repo or no access to upstream repos
9983076
to
1fa9262
Compare
/ok-to-test |
@@ -74,7 +74,11 @@ | |||
{{$EXEC_TIMEOUT := DefaultParam .CL2_EXEC_TIMEOUT "3600s"}} | |||
{{$SLEEP_AFTER_EXEC_DURATION := DefaultParam .CL2_SLEEP_AFTER_EXEC_DURATION "0s"}} | |||
|
|||
{{$latencyPodImage := DefaultParam .CL2_LATENCY_POD_IMAGE "registry.k8s.io/pause:3.9"}} | |||
## Image Repositories | |||
{{$registryK8sRepo := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{$registryK8sRepo := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}} | |
{{$imageRegistry := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}} |
{{$latencyPodImage := DefaultParam .CL2_LATENCY_POD_IMAGE "registry.k8s.io/pause:3.9"}} | ||
## Image Repositories | ||
{{$registryK8sRepo := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}} | ||
{{$gcrRepo := DefaultParam .CL2_GCR_REPO "gcr.io"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field and above seem different registries for different images, I'll defer to this repository's maintainers here, but maybe we should try to find some naming that clarifies a bit more where they're set?
@rackeric: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Sometimes clusters will not have access to upstream image repos. This updates the manifests in the clusterloader2 "load" test to support setting the 2 image repos used via Environment Variables, like the others starting with '.CL', while still keeping the current repos set as defaults. This allows the use of mirrors image repos which may be available to clusters.
.CL2_REGISTRY_K8S_REPO
for registry.k8s.io.CL2_GCR_REPO
for gcr.ioWhich issue(s) this PR fixes:
Fixes # #2704
Special notes for your reviewer: