Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default CoreDNS TTL #48128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

simonhammes
Copy link

Description

The default TTL is 30 seconds. I fixed the explanation to match the Corefile snippet above the text.

Ref: kubernetes/kubernetes@f7f51fa

Now the text matches the Corefile snippet :)

Ref: kubernetes/kubernetes@f7f51fa
Copy link

linux-foundation-easycla bot commented Sep 29, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @simonhammes!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 29, 2024
Copy link

netlify bot commented Sep 29, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c96e82
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f9aea0ec280a0008a09144
😎 Deploy Preview https://deploy-preview-48128--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -112,7 +112,7 @@ The Corefile configuration includes the following [plugins](https://coredns.io/p
* [kubernetes](https://coredns.io/plugins/kubernetes/): CoreDNS will reply to DNS queries
based on IP of the Services and Pods. You can find [more details](https://coredns.io/plugins/kubernetes/)
about this plugin on the CoreDNS website.
- `ttl` allows you to set a custom TTL for responses. The default is 5 seconds.
- `ttl` allows you to set a custom TTL for responses. The default is 30 seconds.
Copy link
Contributor

@sftim sftim Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but the default CoreDNS TTL is not 30 seconds. In other words, CoreDNS has a different default value for this field (I think it's 5 seconds).

Try this:

Suggested change
- `ttl` allows you to set a custom TTL for responses. The default is 30 seconds.
- `ttl` allows you to set a maximum time to live (TTL) for responses. The example above
configures CoreDNS to cache records for up to 30 seconds, even if it receives a
record with a longer TTL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but the default CoreDNS TTL is not 30 seconds.

I know; sorry for shortening the PR title too much. I meant default TTL when deployed through kubeadm (ref: https://github.com/search?q=repo%3Akubernetes%2Fkubernetes%20%2Fttl%20%5B%5Cd%5D%2F&type=code)


But then I completely misunderstood the current wording. My bad.

I was trying to figure out the default TTL inside a K8S cluster and thought the snippet and the text got out of sync.


How about The default configuration above [...]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants