Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_get's drop implementation. #832

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix array_get's drop implementation. #832

merged 2 commits into from
Oct 4, 2024

Conversation

azteca1998
Copy link
Collaborator

I implemented an if statement backwards. This PR fixes it.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 marked this pull request as ready for review October 4, 2024 12:41
Copy link

github-actions bot commented Oct 4, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.211 ± 0.020 3.173 3.240 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.199 ± 0.026 3.149 3.247 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.164 ± 0.018 3.144 3.196 1.00
base factorial_2M.cairo (AOT) 3.230 ± 0.061 3.168 3.340 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.751 ± 0.017 2.732 2.785 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.741 ± 0.022 2.698 2.771 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.728 ± 0.025 2.687 2.766 1.00
base fib_2M.cairo (AOT) 2.747 ± 0.037 2.695 2.825 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.227 ± 0.021 3.205 3.270 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.214 ± 0.017 3.192 3.247 1.05 ± 0.01
head logistic_map.cairo (AOT) 3.088 ± 0.057 3.023 3.182 1.01 ± 0.02
base logistic_map.cairo (AOT) 3.052 ± 0.028 3.005 3.110 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (cfd0f06) to head (9e1eb48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   87.92%   88.11%   +0.19%     
==========================================
  Files         123      123              
  Lines       34959    34974      +15     
==========================================
+ Hits        30737    30819      +82     
+ Misses       4222     4155      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 4, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.753 ± 0.295 10.450 11.139 24.00 ± 0.66
cairo-native (embedded AOT) 3.267 ± 0.023 3.211 3.287 7.29 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 3.299 ± 0.029 3.265 3.352 7.36 ± 0.06
cairo-native (standalone AOT) 0.676 ± 0.006 0.672 0.693 1.51 ± 0.01
cairo-native (standalone AOT with -march=native) 0.448 ± 0.000 0.447 0.449 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.666 ± 0.304 10.329 11.024 1321.29 ± 39.05
cairo-native (embedded AOT) 2.809 ± 0.025 2.773 2.851 348.01 ± 4.19
cairo-native (embedded JIT using LLVM's ORC Engine) 2.836 ± 0.030 2.799 2.879 351.27 ± 4.62
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.01
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.342 ± 0.030 4.302 4.400 61.17 ± 0.46
cairo-native (embedded AOT) 3.103 ± 0.023 3.068 3.137 43.72 ± 0.35
cairo-native (embedded JIT using LLVM's ORC Engine) 3.292 ± 0.025 3.261 3.343 46.37 ± 0.38
cairo-native (standalone AOT) 0.115 ± 0.001 0.114 0.122 1.62 ± 0.02
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.071 0.072 1.00

@azteca1998 azteca1998 added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 0b73f1c Oct 4, 2024
15 checks passed
@azteca1998 azteca1998 deleted the fix-array-get-drop branch October 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants