-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue3538 thermal wheel #3909
base: issue3538_Air2Air_recovery
Are you sure you want to change the base?
Issue3538 thermal wheel #3909
Conversation
Data record that describes wheel speed ratio <code>uSpe</code> versus | ||
heat exchange effectiveness corrections <code>epsCor</code>, i.e., the ratio of the heat exchange effectiveness | ||
to that when the <code>uSpe</code> is <i>1</i>. | ||
The wheel speed ratio <code>uSpe</code> must be increasing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The elements of the vector <code>uSpe</code> should be in ascending order,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the model doc as suggested.
@@ -0,0 +1,26 @@ | |||
within Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics; | |||
record motorEfficiencyParameters | |||
"Record for motor efficiency parameters vs. wheel speed ratio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameters for defining motor efficiency at different wheel speed ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the model doc as suggested.
@@ -0,0 +1,27 @@ | |||
within Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels.BaseClasses.Characteristics; | |||
record heatExchangerEffectivenessParameters | |||
"Record for heat exchanger effectiveness correction vs. wheel speed ratio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameters for defining heat exchanger effectiveness at different wheel speed ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the model doc as suggested.
parameter Real uSpe[:](each min=0) | ||
"Wheel speed ratio"; | ||
parameter Real epsCor[:](each max=1) | ||
"Correction of the heat exchange effectiveness under a given speed ratio"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction of the heat exchange effectiveness at a given speed ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the model doc as suggested.
</p> | ||
<ul> | ||
<li> | ||
wheel speed ratio versus motor percent full-load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better put the wheel speed ratio
at the end, so it will be like:
motor efficiency versus wheel speed ratio
,
sensible heat exchange effectiveness corrections versus wheel speed ratio
,
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the model doc as suggested.
<p> | ||
where <code>P_nominal</code> is the nominal wheel power consumption, | ||
<code>uSpe</code> is the wheel speed ratio, | ||
and the <code>eta</code> is the motor percent full-load efficiency, i.e., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a clear explanation of the eta
, what is it? is it eff(uSpe=x) / eff(uSpe=1), where the
eff(uSpe=x)is the motor efficiency when the speed ratio is
x`?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the detailed explanation as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SenHuang19 Please see inline comments
@JayHuLBL I believe I have addressed all your comments. Could you please resume your review? |
Buildings.Fluid.HeatExchangers.BaseClasses.VariableSpeedThermalWheels
for accounting for the impacts of wheel speed ratios on the wheel performanceBuildings.Fluid.HeatExchangers.ThermalWheels.Sensible.Examples.SpaceCooling
and
Buildings.Fluid.HeatExchangers.ThermalWheels.Latent.Examples.SpaceCooling