Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HAProxy socket type from init configuration #115

Closed
wants to merge 2 commits into from
Closed

Support HAProxy socket type from init configuration #115

wants to merge 2 commits into from

Conversation

mecampbellsoup
Copy link
Contributor

Related to #114.

@mecampbellsoup mecampbellsoup mentioned this pull request Dec 26, 2021
Closed
@mecampbellsoup mecampbellsoup changed the title change the luasocket feature to haproxy sockets Support HAProxy socket type from init configuration Dec 26, 2021
@mecampbellsoup mecampbellsoup force-pushed the luasocket-to-haproxy branch 7 times, most recently from 5ecb5f3 to b5b2f90 Compare December 28, 2021 17:22
@mecampbellsoup
Copy link
Contributor Author

@leafo I guess I should've made the changes to the moon files instead of the .lua files and then run make build to generate the Lua file changes?

@mecampbellsoup mecampbellsoup force-pushed the luasocket-to-haproxy branch 2 times, most recently from bda9256 to 3a008d1 Compare January 9, 2022 18:01
@mecampbellsoup
Copy link
Contributor Author

Hi @leafo, do you know when we might expect your review? Thank you.

mecampbellsoup
mecampbellsoup commented Feb 1, 2022
View reviewed changes
pgmoon-dev-1.rockspec Outdated
@@ -2,7 +2,8 @@ package = "pgmoon"
version = "dev-1"

source = {
url = "git://github.com/leafo/pgmoon.git"
url = "git://github.com/mecampbellsoup/pgmoon.git",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leafo we need this change so that I can ref my rockspec and get our forked pgmoon. After/when this PR is approved let's remove this change before merging 😄

@leafo
Copy link
Owner

leafo commented Feb 4, 2022

The only unanswered issue is about the core global. Is that really the only way to access haproxy, a global variable named core?

@mecampbellsoup
Copy link
Contributor Author

The only unanswered issue is about the core global. Is that really the only way to access haproxy, a global variable named core?

https://www.arpalert.org/src/haproxy-lua-api/1.6/index.html#core-class

@mecampbellsoup
Copy link
Contributor Author

Hi @leafo we are still maintaining our fork and it's a bit cumbersome, did I answer your question about the core class?

@mecampbellsoup
Copy link
Contributor Author

Hi @leafo we are still maintaining our fork and it's a bit cumbersome, did I answer your question about the core class?

@leafo ping, please let us know your thoughts on this PR 🙏

@mecampbellsoup
Copy link
Contributor Author

Closing in favor of #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mecampbellsoup @leafo