Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(AlgebraicGeometry): Introduce Scheme.toSpecΓ #15082

Closed
wants to merge 6 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 23, 2024


Open in Gitpod

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

PR summary eb1d5a5430

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Scheme.toSpecΓ_app_top
+ Scheme.toSpecΓ_naturality
+ Scheme.toSpecΓ_preimage_basicOpen
+ _root_.AlgebraicGeometry.Scheme.toSpecΓ
+ instance (X : Scheme.{u}) [IsAffine X] : IsIso (ΓSpec.adjunction.unit.app X) := @IsAffine.affine X _
+ toOpen_toSpecΓ_app
+ ΓSpec.adjunction_unit_app_app_top
+ ΓSpec.adjunction_unit_map_basicOpen
+ ΓSpec.adjunction_unit_naturality
+ ΓSpec.adjunction_unit_naturality_assoc
- adjunction_unit_app_app_top
- adjunction_unit_map_basicOpen
- adjunction_unit_naturality
- toOpen_unit_app_val_c_app
- toOpen_unit_app_val_c_app'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@erdOne
Copy link
Member Author

erdOne commented Jul 23, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d568375.
The entire run failed.
Found no significant differences.

@erdOne
Copy link
Member Author

erdOne commented Jul 24, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6c86c0b.
There were no significant changes against commit 4261f99.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Aug 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 22, 2024

Build failed:

@jcommelin
Copy link
Member

Let's try again

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Build failed:

@sgouezel
Copy link
Contributor

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Build failed (retrying...):

@urkud
Copy link
Member

urkud commented Aug 30, 2024

The build error looks like category theory, removing from the queue for now.
bors r-
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Canceled.

@urkud urkud removed the ready-to-merge This PR has been sent to bors. label Aug 30, 2024
@erdOne
Copy link
Member Author

erdOne commented Oct 3, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Andrew Yang <[email protected]>
Co-authored-by: Yury G. Kudryashov <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(AlgebraicGeometry): Introduce Scheme.toSpecΓ [Merged by Bors] - refactor(AlgebraicGeometry): Introduce Scheme.toSpecΓ Oct 3, 2024
@mathlib-bors mathlib-bors bot closed this Oct 3, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/toSpecGamma branch October 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants