Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): Residue fields of schemes. #15333

Closed
wants to merge 4 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 30, 2024


Open in Gitpod

Copy link

github-actions bot commented Jul 30, 2024

PR summary 0729aa8439

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.ResidueField 1635

Declarations diff

+ Hom.residueFieldMap
+ evaluation
+ evaluation_eq_zero_iff_not_mem_basicOpen
+ evaluation_naturality
+ evaluation_naturality_apply
+ evaluation_ne_zero_iff_mem_basicOpen
+ fromSpecResidueField
+ germ_residue
+ instance (X : Scheme.{u}) (x) : Epi (X.residue x)
+ instance (x : X) : Field (X.residueField x)
+ instance (x) : IsLocalRingHom (f.stalkMap x) := inferInstanceAs (IsLocalRingHom (f.val.stalkMap x))
+ instance [IsOpenImmersion f] (x) : IsIso (f.residueFieldMap x)
+ residue
+ residueField
+ residueFieldCongr
+ residueFieldCongr_fromSpecResidueField
+ residueFieldCongr_inv
+ residueFieldCongr_refl
+ residueFieldCongr_symm
+ residueFieldCongr_trans
+ residueFieldCongr_trans_hom
+ residueFieldMap_comp
+ residueFieldMap_id
+ residue_residueFieldCongr
+ residue_residueFieldMap
+ residue_surjective
+ Γevaluation

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Jul 30, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Comment on lines 15 to 17
The following are in the `AlgebraicGeometry.LocallyRingedSpace` namespace:

- `AlgebraicGeometry.Scheme.residueField`: The residue field of the stalk at `x`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it AlgebraicGeometry.LocallyRingedSpace or AlgebraicGeometry.Scheme?

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 22, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@erdOne
Copy link
Member Author

erdOne commented Oct 3, 2024

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): Residue fields of schemes. [Merged by Bors] - feat(AlgebraicGeometry): Residue fields of schemes. Oct 3, 2024
@mathlib-bors mathlib-bors bot closed this Oct 3, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/residueField branch October 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants