-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(GroupTheory/Archimedean): LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered
#15846
Conversation
This allows one to talk about finding powers greater than some element for ordered monoids Before, this was only available for ordered semirings This is to later installthe instance on valuation groups (`LinearOrderedCommGroupWithZero`) Install the instance on NNRat and NNReal (though they are ordered semirings) Also, add some misisng instances about the nonnegative submonoid
…_denselyOrdered` Classfy linearly ordered additive groups, either they are discrete (order isomorphic to Int) or densely ordered Also add some simple lemmas about the closure subgroup.
…ize-group-archimedean
…ltiplicativize-group-archimedean
…te_or_denselyOrdered` Along with helper equivs about `Units` and some missing instances about `Units`.
PR summary 3db831ab74Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for |
Co-authored-by: Yaël Dillies <[email protected]>
This reverts commit 83d4c43.
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Can you please merge master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
bors merge |
…te_or_denselyOrdered` (#15846) Co-authored-by: Yakov Pechersky <[email protected]>
Pull request successfully merged into master. Build succeeded: |
LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered
LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered
ℤₘ₀
notation earlier, under Multiplicative scope #16873