Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(GroupTheory/Archimedean): LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered #15846

Closed
wants to merge 72 commits into from

Conversation

This allows one to talk about finding powers greater than some element for ordered monoids
Before, this was only available for ordered semirings
This is to later installthe instance on valuation groups (`LinearOrderedCommGroupWithZero`)
Install the instance on NNRat and NNReal (though they are ordered semirings)
Also, add some misisng instances about the nonnegative submonoid
…_denselyOrdered`

Classfy linearly ordered additive groups, either they are discrete (order isomorphic to Int) or densely ordered
Also add some simple lemmas about the closure subgroup.
…te_or_denselyOrdered`

Along with helper equivs about `Units`
and some missing instances about `Units`.
@pechersky pechersky added t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

PR summary 3db831ab74

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered
+ Units.instMulArchimedean

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 15, 2024
@YaelDillies YaelDillies self-assigned this Aug 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 27, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 14, 2024
@pechersky pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 15, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 16, 2024
@pechersky pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 16, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 16, 2024
@pechersky pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 16, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Sep 17, 2024
@YaelDillies
Copy link
Collaborator

Can you please merge master?

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@kim-em
Copy link
Contributor

kim-em commented Sep 18, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 18, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(GroupTheory/Archimedean): LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered [Merged by Bors] - feat(GroupTheory/Archimedean): LinearOrderedCommGroupWithZero.discrete_or_denselyOrdered Sep 18, 2024
@mathlib-bors mathlib-bors bot closed this Sep 18, 2024
@mathlib-bors mathlib-bors bot deleted the pechersky/linear-ordered-comm-with-zero branch September 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants