Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant lemma LinearMap.IsSymmetric.eigenspace_invariant_of_commute #16915

Closed
wants to merge 1 commit into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Sep 18, 2024


I noticed that #15012 seemed to prove a few results with unnecessarily strong assumptions (mostly, working over or when any commutative ring would suffice). I don't have time to generalise it all but I thought I'd highlight this observation with this small PR.

Open in Gitpod

@ocfnash ocfnash added the t-algebra Algebra (groups, rings, fields, etc) label Sep 18, 2024
Copy link

PR summary 5ae32b7ca0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- eigenspace_invariant_of_commute

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@JonBannon
Copy link
Collaborator

This is amazing, Oliver. Jireh just suggested that I remove that lemma and make this fix using generalized eigenspaces. Thanks!

Copy link
Collaborator

@JonBannon JonBannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@JonBannon
Copy link
Collaborator

Also, thanks for the suggestion about the commutative rings. We are finishing up a PR for finite tuples and will fold in the weakened assumptions throughout with that PR.

@ocfnash
Copy link
Contributor Author

ocfnash commented Sep 18, 2024

Great news! Thanks so much @JonBannon 🎉

@j-loreaux
Copy link
Collaborator

Thanks! I think we'll just fold these suggestions (and the generalization to CommRing) into #16569, and thereby avoid the merge conflict. I'm closing this for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants