Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(Algebra/Field/Subfield): minor golfing #17376

Closed

Conversation

pitmonticone
Copy link
Collaborator

@pitmonticone pitmonticone commented Oct 3, 2024

No description provided.

@pitmonticone pitmonticone added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

PR summary 6b76a903b4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added t-algebra Algebra (groups, rings, fields, etc) and removed awaiting-CI labels Oct 3, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

github-actions bot commented Oct 3, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 4, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Algebra/Field/Subfield): minor golfing [Merged by Bors] - refactor(Algebra/Field/Subfield): minor golfing Oct 4, 2024
@mathlib-bors mathlib-bors bot closed this Oct 4, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/Algebra-Field-Subfield-golf branch October 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants