Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Array/Option.unattach #5586

Merged
merged 8 commits into from
Oct 3, 2024
Merged

feat: Array/Option.unattach #5586

merged 8 commits into from
Oct 3, 2024
+387 −24

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 2, 2024

More support for automatically removing .attach, for Array and Option.

@kim-em kim-em requested a review from digama0 as a code owner October 2, 2024 04:35
@kim-em kim-em mentioned this pull request Oct 2, 2024
Closed
@kim-em kim-em enabled auto-merge October 2, 2024 04:35
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 04:45 Inactive
@kim-em kim-em added this pull request to the merge queue Oct 2, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9322d8d6393f5ec6f140e4e17ffc578832a63122 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-02 04:58:03)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a01166f045ce5d118a61d743af3b66e5a135af87 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-03 06:19:30)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 341c64a306919ecc863b6624cae21320b6bc68bd --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-03 07:31:13)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@kim-em kim-em added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@kim-em kim-em added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@kim-em kim-em enabled auto-merge October 3, 2024 06:02
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 3, 2024 06:18 Inactive
@kim-em kim-em added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@kim-em kim-em enabled auto-merge October 3, 2024 07:06
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 3, 2024 07:20 Inactive
@kim-em kim-em added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit a4fda01 Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot